Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - when settign deleteAll to false tis deletes the flags. #29

Open
rtmzshw opened this issue Oct 12, 2019 · 5 comments
Open

BUG - when settign deleteAll to false tis deletes the flags. #29

rtmzshw opened this issue Oct 12, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@rtmzshw
Copy link

rtmzshw commented Oct 12, 2019

when setting deleteAll property to false and trying to remove a letter from the end of the word, it deletes the special letter and ruins the style of the span.
way to reproduce - use the example folder and just change deleteAll from true to false in dollar_text.dart folder. then go to custom selection toolbar example and try to delete a letter from the end of the word "FlutterCandies".
thank you for your time.

@zmtzawqlp
Copy link
Member

zmtzawqlp commented Oct 12, 2019

as design

#FlutterCandies# has style
#FlutterCandies is no style

i can't konw you want to delete # or s , #FlutterCandies# is actual text, FlutterCandies just show text.

@rtmzshw
Copy link
Author

rtmzshw commented Oct 12, 2019

I would never want to delete the # because as a user, I can't see it, and I don't know about it exists.
the algorithm should treat this case and fix it.
something like - if a flag has been deleted, remove the letter before/after the flag.
if you can aim me to the code that responsible for that, I would be glad to submit a pull request.

@zmtzawqlp
Copy link
Member

we can't see # ,so we will never delete it? i don't think it's a bug. the code is not simple as you thought, they are refer to native keyboard and complex calculations

-I would never want to delete the # -
this is just you thought, that's not what everyone thinks

@rtmzshw
Copy link
Author

rtmzshw commented Oct 12, 2019

how can one want to delete something he doesn't know about it exists? I cant understand that.
I understand it is a complex issue to solve, but I think it a really important one.
you don't think it a bug? you don't think that if I misspelled a word I should be able to fix it?
as I mentioned, I would love to help. you can contact me - rtmzshw@gmail.com if you want to explain to me the complexity, and ill try to solve it with PR.
any case thank you for your time and responses.

@zmtzawqlp
Copy link
Member

more investigate for this case.

  1. the text in native keyboard must be actual text
  2. we don't konw end flag of your special text in native keyboard
  3. we can't move delete symbol, we don't konw we should move to where

Specila text is considered to a whole, so i provide "delete all"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants