Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Microsoft.Extensions.FileProviders.EmbeddedFileProvider #1396

Open
jzabroski opened this issue Dec 20, 2020 · 0 comments
Open

Consider Microsoft.Extensions.FileProviders.EmbeddedFileProvider #1396

jzabroski opened this issue Dec 20, 2020 · 0 comments
Labels
feature A new feature (we all like those)

Comments

@jzabroski
Copy link
Collaborator

We have our own IEmbeddedResourceProvider and DefaultEmbeddedResourceProvider today. It might make more sense to use Microsoft.Extensions.FileProviders.EmbeddedFileProvider.

The biggest con is it doesn't make sense to support both interfaces (so we either make a breaking change or increase code complexity). The biggest pro would be standardization.
@jzabroski jzabroski added the feature A new feature (we all like those) label Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature (we all like those)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jzabroski