Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append file support #433

Open
raultang opened this issue Dec 7, 2023 · 3 comments
Open

Append file support #433

raultang opened this issue Dec 7, 2023 · 3 comments

Comments

@raultang
Copy link

raultang commented Dec 7, 2023

Is your feature request related to a problem? Please describe.

From my current understanding, log file is visible after a timekey interval or a buffer size.
If we configure with short time range there should have many files generated in case log content itself is not big.
If we configure with large time range then we need wait quite some time for log visibility.

Describe the solution you'd like

S3 support append semantic, so maybe we can implement with append file instead of put semantic.

Describe alternatives you've considered

File/WebHdfs plugin seems support append files.

Additional context

No response

@daipom
Copy link
Contributor

daipom commented Dec 7, 2023

Thanks for your request.
I don't know why the current out_s3 plugin doesn't support the append feature.
If anyone knows any reason, please let me know.

You mean that if we want to make a large file unit, we have to keep it in the buffer for a long period of time, and it is inconvenient, right?

If you have any sample implementations, I would appreciate it if you could share them.
Or PRs are welcome!

@raultang
Copy link
Author

raultang commented Dec 7, 2023

You mean that if we want to make a large file unit, we have to keep it in the buffer for a long period of time, and it is inconvenient, right?

We want to make the log file visible as soon as possible: if with short timekey, there might have many small files.

If anyone knows any reason, please let me know.

Ok, After read s3 documents, S3 itself not support append :)

@daipom
Copy link
Contributor

daipom commented Jan 30, 2024

Sorry for my late response.

We want to make the log file visible as soon as possible: if with short timekey, there might have many small files.

I see!!

Ok, After read s3 documents, S3 itself not support append :)

Thanks!
So, S3 support append semantic was not correct?
Do you mean S3 does not support append, so it seems difficult to add append feature to out_s3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants