Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit() does not call handleError on exception. #172

Open
klarose opened this issue Jan 28, 2021 · 0 comments
Open

emit() does not call handleError on exception. #172

klarose opened this issue Jan 28, 2021 · 0 comments
Labels

Comments

@klarose
Copy link

klarose commented Jan 28, 2021

The documentation for the handleError function of logging.Handler implies that exceptions should be caught by emit and handled by invoking handleError. This allows the environment to customer how logging errors are handled.

The fluent logger Handler does not do this:

data = self.format(record)

The net result is that exceptions triggered when running the fluent logger (either in format or otherwise) are raised, as opposed to log, which is inconsistent with the rest of the logging Handlers.

The fluent logger should call handleError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants