Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this package be used with TLS? #144

Open
itaiMona opened this issue Dec 7, 2018 · 3 comments
Open

Can this package be used with TLS? #144

itaiMona opened this issue Dec 7, 2018 · 3 comments

Comments

@itaiMona
Copy link

itaiMona commented Dec 7, 2018

Hi,
I'm using fluent-logger with a fluentd instance on a remote host and would like to secure the data transfer using TLS.

On the fluentd side, I follow the instructions set here.

IIUC, there's no support for TLS/SSL on this package yet, and in order to get that, we need to wrap the socket when needed (e.g., given a parameter in the sender's constructor) as described here.

Please tell me if I'm getting something wrong here, and if not, may I submit a pull request with this functionality?

@itaiMona
Copy link
Author

itaiMona commented Dec 9, 2018

Please see my fork of this package where I was able to make it work with TLS:
https://github.com/itaiMona/fluent-logger-python

I'd love to create a pull request and merge this code back here. Would love guidance and pointers for what I should change further in my code to do that.

Thanks!

@buanzo
Copy link

buanzo commented Apr 25, 2020

Hi, I am currently pursuing an open source project that involves fluentd and python. I am reviewing the available packages, and I noticed @itaiMona fork - Will the PR make it into mainline?

@DavidHe1127
Copy link

Can we support TLS in parity with https://www.npmjs.com/package/fluent-logger#tlsssl-encryption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants