Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links are "swallowed" #3

Open
bwaidelich opened this issue Mar 30, 2020 · 3 comments
Open

Broken links are "swallowed" #3

bwaidelich opened this issue Mar 30, 2020 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@bwaidelich
Copy link
Collaborator

The following Code in ConverUrisImplementation::evaluate():

        try {
            return parent::evaluate();
        } catch (\Throwable $e) {
            return '';
        }

leads to a blank page if there is one link that couldn't be converted – even in Dev context.

It should probably be something like

return $this->fusionValue('value');

in conclusion with some logging

@bwaidelich
Copy link
Collaborator Author

..that in turn will just disable the whole feature if there is one broken link in the affected area.
I.e. if you apply the convertUris processor to the whole body, all node links will be node://<uuid> if one does not resolve..

@bwaidelich
Copy link
Collaborator Author

This is probably resolved with #6

@kdambekalns
Copy link
Member

@bwaidelich Is this still an issue?

@kdambekalns kdambekalns self-assigned this Jan 21, 2022
@kdambekalns kdambekalns added the question Further information is requested label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants