Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripped Authorization header in Apache since v2.4.13 runs in trouble with this package #9

Open
2case opened this issue Feb 24, 2022 · 5 comments

Comments

@2case
Copy link
Contributor

2case commented Feb 24, 2022

We run in some trouble while Apache strip the Authorization header since version 2.4.13. You have to add

SetEnvIf Authorization "(.*)" HTTP_AUTHORIZATION=$1

to your .htaccess to enable it.

1 similar comment
@2case
Copy link
Contributor Author

2case commented Feb 25, 2022

No, since that only triggert on Basic authentication and not on Bearer authentication. Also the destination $_SERVER key is different (HTTP_ vs REMOTE_ not sure if the flow/neos subsystem triggers on that)

@kitsunet
Copy link
Member

In general I found that the current code for the token from headers is really brittle, it needs to account for Authentication headers being an arry, for Basic authentication AND it has no way to know if the Bearer token was actually meant for it. IMHO there should be a way to identify the token to make sure it was actually meant to be a token auth token? Maybe that is fine though as the repo will just return null and we can then ignore the result...

@kdambekalns
Copy link
Member

I can't tell much about this, as I have mot been using Apache HTTPD for ages now.

But I would think this is rather an issue with the Apache setup, and as such this package does not need to be changed – except maybe mentioning possible problems in the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants