Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js tests failing #385

Open
jonnor opened this issue Dec 4, 2018 · 10 comments
Open

Node.js tests failing #385

jonnor opened this issue Dec 4, 2018 · 10 comments
Labels
bug

Comments

@jonnor
Copy link
Member

jonnor commented Dec 4, 2018 •
edited

Happens at least on Travis CI. For example: https://travis-ci.org/flowhub/the-graph/builds/454191240

Because of this they are currently disabled in Grunt.
@jonnor jonnor added the bug label Dec 4, 2018
@jonnor jonnor mentioned this issue Dec 4, 2018
Closed
@davecarlson
Copy link
Contributor

Now using node v10.12.0 (npm v6.4.1)

Running "exec:jest" (exec) task
>> FAIL __tests__/editing.js
>> Editor navigation
>> dragging on background
>> ✕ should pan graph view (59ms)
>>     mouse scrolling up
>> ✕ should zoom in (17ms)
>>     mouse scrolling down
>>       ✕ should zoom out (17ms)
>>     multitouch pinch
>>       ✕ should zoom in/out (13ms)
>>     hovering an node
>>       ○ skipped 1 test
>>     hovering an edge
>>       ○ skipped 1 test
>>     hovering exported port
>>       ○ skipped 1 test
>>     hovering node group
>>       ○ skipped 1 test
>>   Editor
>>     dragging on node
>> ✕ should move the node (15ms)
>>     dragging on exported port
>>       ○ skipped 1 test
>>     dragging from node port
>> ✕ should start making edge (14ms)
>>     dropping started edge on port
>>       ✕ should connect the edge (18ms)
>>     dropping started edge outside
>> ✕ should not connect the edge (18ms)
>>     clicking exported port
>>       ○ skipped 1 test
>>     clicking unselected node
>> ✕ should add node to selection (20ms)
>>     clicking selected node
>>       ✕ should remove node from selection (12ms)
>> clicking unselected edge
>>       ○ skipped 1 test
>>     clicking selected edge
>> ○ skipped 1 test
>>     selected nodes
>>       ○ skipped 1 test
>> when dragging the box
>>         ○ skipped 1 test
>>     node groups
>> ○ skipped 3 tests
>>       when dragging on label
>>         ○ skipped 1 test
>>       when dragging on bounding box
>> ○ skipped 1 test
>>     right-click node
>>       ○ skipped 1 test
>> right-click node port
>>       ○ skipped 1 test
>>     right-click edge
>> ○ skipped 1 test
>>     right-click exported port
>>       ○ skipped 1 test
>> right-click node group
>>       ○ skipped 1 test
>>     right-click background
>> ○ skipped 1 test
>>     long-press
>>       ○ skipped 1 test
>>   Editor menus
>> node menu
>>       ○ skipped 5 tests
>>       clicking port
>> ○ skipped 1 test
>>     node port menu
>>       ○ skipped 1 test
>> edge menu
>>       ○ skipped 2 tests
>>     exported port menu
>> ○ skipped 1 test
>>     node selection menu
>>       ○ skipped 2 tests
>> editor menu
>>       ○ skipped 1 test
>> ● Editor navigation › dragging on background › should pan graph view
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › dragging on background › should pan graph view
>> 
>>     TypeError: Cannot read property 'state' of undefined
>>       
>>       at Object.it (__tests__/editing.js:57:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › dragging on background › should pan graph view
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › mouse scrolling up › should zoom in
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › mouse scrolling up › should zoom in
>> 
>>     TypeError: Cannot read property 'state' of undefined
>>       
>>       at Object.it (__tests__/editing.js:70:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › mouse scrolling up › should zoom in
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › mouse scrolling down › should zoom out
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › mouse scrolling down › should zoom out
>> 
>>     TypeError: Cannot read property 'state' of undefined
>>       
>>       at Object.it (__tests__/editing.js:82:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › mouse scrolling down › should zoom out
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › multitouch pinch › should zoom in/out
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>> at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › multitouch pinch › should zoom in/out
>> 
>>     TypeError: Cannot read property 'state' of undefined
>>       
>>       at Object.it (__tests__/editing.js:93:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor navigation › multitouch pinch › should zoom in/out
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dragging on node › should move the node
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dragging on node › should move the node
>> 
>>     TypeError: Cannot read property 'props' of undefined
>>       
>>       at Object.it (__tests__/editing.js:152:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dragging on node › should move the node
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dragging from node port › should start making edge
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dragging from node port › should start making edge
>> 
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>       
>>       at Object.it (__tests__/editing.js:172:18)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dragging from node port › should start making edge
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dropping started edge on port › should connect the edge
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (no
>> de_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dropping started edge on port › should connect the edge
>> 
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>       
>>       at Object.it (__tests__/editing.js:185:29)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dropping started edge on port › should connect the edge
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dropping started edge outside › should not connect the edge
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dropping started edge outside › should not connect the edge
>> 
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>       
>>       at Object.it (__tests__/editing.js:206:7)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › dropping started edge outside › should not connect the edge
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › clicking unselected node › should add node to selection
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › clicking unselected node › should add node to selection
>> 
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>       
>>       at Object.it (__tests__/editing.js:225:20)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › clicking unselected node › should add node to selection
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › clicking selected node › should remove node from selection
>> 
>>     TypeError: Cannot read property 'clearRect' of null
>>       
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.n
>> otifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › clicking selected node › should remove node from selection
>> 
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>       
>>       at Object.it (__tests__/editing.js:234:20)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> 
>>   ● Editor › clicking selected node › should remove node from selection
>> 
>>     TypeError: Cannot read property 'unmount' of undefined
>>       
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> PASS __tests__/basics.js
>>   Basics
>>     loading a simple graph
>>       ✓ should render 2 nodes (3ms)
>>       ✓ should render 1 edge
>>       ✓ should render 1 IIP (1ms)
>> Test Suites: 1 failed, 3 skipped, 1 passed, 2 of 5 total
>> Tests:       10 failed, 51 skipped, 3 passed, 64 total
>> Snapshots:   0 total
>> Time:        1.527s, estimated 3s
>> Ran all test suites.
>> Exited with code: 1.
>> Error executing child process: Error: Process exited with code 1.
Warning: Task "exec:jest" failed. Use --force to continue.

@davecarlson
Copy link
Contributor

Now using node v8.12.0 (npm v6.4.1)

Running "exec:jest" (exec) task
>> PASS __tests__/editing.js
>> Editor navigation
>> dragging on background
>> ✓ should pan graph view (562ms)
>>     mouse scrolling up
>> ✓ should zoom in (22ms)
>>     mouse scrolling down
>>       ✓ should zoom out (19ms)
>>     multitouch pinch
>>       ✓ should zoom in/out (25ms)
>>     hovering an node
>>       ○ skipped 1 test
>>     hovering an edge
>>       ○ skipped 1 test
>>     hovering exported port
>> ○ skipped 1 test
>>     hovering node group
>>       ○ skipped 1 test
>>   Editor
>>     dragging on node
>> ✓ should move the node (19ms)
>>     dragging on exported port
>>       ○ skipped 1 test
>> dragging from node port
>> ✓ should start making edge (23ms)
>>     dropping started edge on port
>> ✓ should connect the edge (24ms)
>>     dropping started edge outside
>>       ✓ should not connect the edge (20ms)
>> clicking exported port
>>       ○ skipped 1 test
>>     clicking unselected node
>> ✓ should add node to selection (20ms)
>>     clicking selected node
>> ✓ should remove node from selection (13ms)
>>     clicking unselected edge
>>       ○ skipped 1 test
>> clicking selected edge
>>       ○ skipped 1 test
>>     selected nodes
>> ○ skipped 1 test
>>       when dragging the box
>>         ○ skipped 1 test
>> node groups
>>       ○ skipped 3 tests
>>       when dragging on label
>> ○ skipped 1 test
>>       when dragging on bounding box
>> ○ skipped 1 test
>>     right-click node
>>       ○ skipped 1 test
>> right-click node port
>>       ○ skipped 1 test
>>     right-click edge
>> ○ skipped 1 test
>>     right-click exported port
>>       ○ skipped 1 test
>> right-click node group
>>       ○ skipped 1 test
>>     right-click background
>> ○ skipped 1 test
>>     long-press
>>       ○ skipped 1 test
>> Editor menus
>>     node menu
>> ○ skipped 5 tests
>>       clicking port
>>         ○ skipped 1 test
>> node port menu
>>       ○ skipped 1 test
>>     edge menu
>> ○ skipped 2 tests
>>     exported port menu
>>       ○ skipped 1 test
>>     node selection menu
>> ○ skipped 2 tests
>>     editor menu
>> ○ skipped 1 test
>> PASS __tests__/basics.js
>>   Basics
>> loading a simple graph
>>       ✓ should render 2 nodes (3ms)
>>       ✓ should render 1 edge (1ms)
>>       ✓ should render 1 IIP
>> Test Suites: 3 skipped, 2 passed, 2 of 5 total
>> Tests:       51 skipped, 13 passed, 64 total
>> Snapshots:   0 total
>> Time:        2.174s
>> Ran all test suites.

Done.

@davecarlson
Copy link
Contributor

As you can see, passes on Node 8 LTS, but fails on Node 10

@jonnor
Copy link
Member Author

jonnor commented Dec 4, 2018

Thats great info. But that failure is actually separate from what happens on Travis, which is from grunt mochaTest (not part of grunt test/npm test since 5 minutes ago). Below is error copied from Travis:

Running "mochaTest:nodejs" (mochaTest) task
the-graph-render
with no options
1) should output PNG file
requesting JPEG
2) should output JPEG file
requesting SVG
- should output SVG file
0 passing (4s)
1 pending
2 failing

  1. the-graph-render
    with no options
    should output PNG file:
    Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
    Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
    Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
    Error: Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
    Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

  at ChildProcess.exithandler (child_process.js:289:12)
  at ChildProcess.EventEmitter.emit (domain.js:442:20)
  at maybeClose (internal/child_process.js:962:16)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)
  1. the-graph-render
    requesting JPEG
    should output JPEG file:
    Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --format jpeg --quality 1 --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
    Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
    Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
    Error: Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --format jpeg --quality 1 --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
    Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

  at ChildProcess.exithandler (child_process.js:289:12)
  at ChildProcess.EventEmitter.emit (domain.js:442:20)
  at maybeClose (internal/child_process.js:962:16)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

@davecarlson
Copy link
Contributor

Yes - but if the main tests fail on node 10, then maybe whatever is breaking the mocha ones is also effecting these :)

@davecarlson
Copy link
Contributor

I'll run those through both nodes to confirm

@davecarlson
Copy link
Contributor

davecarlson commented Dec 4, 2018 •
edited

If you try to run the command outside of mocha directly, you get the same error:

/Users/me/Code/the-graph/bin/the-graph-render /Users/me/Code/the-graph/spec/fixtures/photobooth.json --format jpeg --quality 1 --output /Users/me/Code/the-graph/spec/temp/rendered.tmp
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess.<anonymous> (/Users/me/Code/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)

Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
    at ChildProcess.<anonymous> (/Users/me/Code/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)

@davecarlson
Copy link
Contributor

davecarlson commented Dec 4, 2018 •
edited

Should the coffeescript in jsjob not be transpiled ?

I also notice there's a few warning on that package that other updates break it's build: https://github.com/flowhub/jsjob/issues

@davecarlson
Copy link
Contributor

I've been doing some testing on jsjob - there's a lot of failing tests on it's master branch.
(I also had to include coffeescript as a dependancy, as it was looking for coffee-script - the package has been renamed).

@Vkrish-Nimmagadda
Copy link

Vkrish-Nimmagadda commented Oct 11, 2019 •
edited

This issue is not fixed yet. Is anyone working on this ? Request kind help. It is breaking with the exact same problem on Node v12.11.1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonnor @davecarlson @Vkrish-Nimmagadda