Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output hangs during docker push #186

Open
alehatsman opened this issue Apr 10, 2018 · 2 comments
Open

Output hangs during docker push #186

alehatsman opened this issue Apr 10, 2018 · 2 comments

Comments

@alehatsman
Copy link
Contributor

I noticed that output doesn't refresh during docker push.

The output that is displayed:

Console Output
The push refers to repository [registry.private.io/myapp]
aee34d46f03a: Preparing
5336f19caf45: Preparing
20dd87a4c2ab: Preparing
78075328e0da: Preparing
9f8566ee5135: Preparing
78075328e0da: Layer already exists
20dd87a4c2ab: Layer already exists
9f8566ee5135: Layer already exists
5336f19caf45: Layer already exists
@flosell
Copy link
Owner

flosell commented Apr 11, 2018

So this is the only output you see?

To debug this, could you have a look at the data that's coming from the API (http://<host>:<port>/api/builds/<build-number>/) and the data that's stored in the lambdacd-home directory (<dir>/build-<build-numer>/build-state.edn) and share the relevant parts?

Docker does a bit of ANSI-Escape magic for this output so my guess is that LambdaCD isn't processing this quite right.

@flosell
Copy link
Owner

flosell commented Oct 23, 2018

Just had a look at this, from what I can tell, docker internally detects if it's running inside an interactive terminal. If not it just displays the raw text output you are seeing.

There's probably a way to override this or fake a TTY, however I'm not sure if it's worth the effort. I feel there are a few different implementations out there for this kind of detection so even if we make it work for docker, lots of other tools might still have similar problems.
Also, this kind of detection is usually there for good reason, e.g. to disable behaviour that only makes sense on an interactive terminal so overriding it might also lead to unpredictable behaviour.

For those reasons, I don't think I'll invest too much time into it unless it's a bigger problem (correct me if I'm wrong, to me it sounds like a minor annoyance, not a major issue).

I'd welcome contributions though if someone finds an elegant way to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants