Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landscape fullscreen input shows in portrait #2474

Closed
klaurence opened this issue May 13, 2024 · 1 comment · Fixed by #2475
Closed

Landscape fullscreen input shows in portrait #2474

klaurence opened this issue May 13, 2024 · 1 comment · Fixed by #2475
Assignees
@lm41
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@klaurence
Copy link
Contributor

klaurence commented May 13, 2024 •
edited

Short description

When Landscape fullscreen input is set to Always show, your phone is in portrait, and you focus on an input box, the Florisboard text box appears.

I'm not sure if this portrait orientation behavior should be intentional. If it should be, Landscape fullscreen input should be renamed to Fullscreen input. If it shouldn't be, it should be fixed.

Steps to reproduce

  1. Go to Settings > Keyboard and set Landscape fullscreen input to Always show.
  2. Rotate your phone to portrait.
  3. Tap an input box.

FlorisBoard Version

0.4.0-beta02

Install Source

Google PlayStore

Android

10
@klaurence klaurence added the bug A bug report label May 13, 2024
@patrickgold
Copy link
Member

Definitely a bug and fully reproducible for me

@patrickgold patrickgold added area: kbd-ui Issues with the front-end of the keyboard rendering view bug-confirmed A confirmed and reproducible bug report labels May 13, 2024
lm41 added a commit to lm41/florisboard that referenced this issue May 13, 2024
@lm41
Fix fullscreen input mode in portrait orientation (florisboard#2474)
a554496
@lm41 lm41 mentioned this issue May 13, 2024
Merged
@lm41 lm41 self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lm41 lm41

Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fullscreen input mode in portrait orientation lm41/florisboard
3 participants
@klaurence @patrickgold @lm41