Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System navigation bar is not correctly rendered sometimes #2461

Open
Ansarmughal99 opened this issue Apr 27, 2024 · 5 comments
Open

System navigation bar is not correctly rendered sometimes #2461

Ansarmughal99 opened this issue Apr 27, 2024 · 5 comments
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@Ansarmughal99
Copy link

Short description

Sometime the space below the keyboard shows different color look like it is background color which match with homescreen wallpaper. But sometime the color is same as keyboard material color.
See image attached
IMG_20240427_155417

Steps to reproduce

  1. Go to '…'
  2. Click on '…'
  3. Scroll down to '…'
  4. See error

FlorisBoard Version

0.4.0 beta 2

Install Source

GitHub

Device

realme gt neo 2

Android

Android 13

@Ansarmughal99 Ansarmughal99 added the bug A bug report label Apr 27, 2024
@itsmartashub
Copy link

itsmartashub commented Apr 27, 2024

I just want to make sure, but I can't conclude 100% from the cropped screenshot. Do you use gestures or navigation buttons for the system navigation? If you use gestures, is your full-screen indicator shown or hidden? Just so I know which navigation mode to test at least the theme.
Even the color of the submit button stands out a bit, as if the theme didn't apply properly. Also, have you noticed if this happens immediately after changing the wallpaper, or randomly?

I recently experienced a bug when I switched to a new ROM, where when I changed the wallpaper, the theme wasn't properly applied to Florisboard, and the colors were somehow mixed with the previous theme (from the previous wallpaper). However, I just exited the text field and dismissed the keyboard, then re-entered the typing field to make the keyboard reappear, and the theme applied properly. However, I thought this was a small bug in the new ROM, hm

@patrickgold
Copy link
Member

patrickgold commented Apr 27, 2024

This bug is actually related to the fact that the system UI helpers of Google Accompanist are not actively maintained anymore and I have to get creative once again fixing the background color. The issue is that the system navigation bar (the bar with the gesture bubble or the classic 3 buttons) is system space but apps have some sort of control over it, although it is only partially documented and not the most stable system API...

Ofc that doesn't mean there isn't an issue with the internal theme handling too, if colors within the keyboard area are messed up for instance.

@patrickgold patrickgold added area: kbd-ui Issues with the front-end of the keyboard rendering view bug-confirmed A confirmed and reproducible bug report labels Apr 27, 2024
@patrickgold
Copy link
Member

Here is a screenshot of the bug occurring, took me some tries to force it (as it often times still works as intended):

Screenshot_2024-04-27-14-44-37-95_c853220993b0ed55eb2e57645fcd343d

And another occurrence in Spotify, here you see a very good demonstration that keyboards in Android basically just overdraw the app:

Screenshot_2024-04-27-14-47-28-87_0438eb925998df20b3482ec25499d226

@patrickgold patrickgold changed the title Space below the keybaord System navigation bar is not correctly rendered sometimes Apr 27, 2024
@Ansarmughal99
Copy link
Author

Ansarmughal99 commented Apr 27, 2024 via email

@itsmartashub
Copy link

This bug is actually related to the fact that the system UI helpers of Google Accompanist are not actively maintained anymore and I have to get creative once again fixing the background color. The issue is that the system navigation bar (the bar with the gesture bubble or the classic 3 buttons) is system space but apps have some sort of control over it, although it is only partially documented and not the most stable system API...

I get that it’s tough with the Google Accompanist system UI helpers not being maintained anymore. It sounds like a real challenge to come up with creative fixes for the background color issue. Your efforts to sort this out despite those hurdles are really appreciated, Patrick 🥹

Ofc that doesn't mean there isn't an issue with the internal theme handling too, if colors within the keyboard area are messed up for instance.

I checked the internal theme handling and found a small "issue". When changing the theme while the keyboard is open, some material you colors from the previous wallpaper, mix with the new wallpaper's colors. However, closing and opening the keyboard fixes the issue. So, not a big deal I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

No branches or pull requests

3 participants