Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Documents #162

Open
Mortagus opened this issue Mar 21, 2017 · 12 comments
Open

Nested Documents #162

Mortagus opened this issue Mar 21, 2017 · 12 comments

Comments

@Mortagus
Copy link

Hello everyone,

I'm working now on a proof of concept about Solr documents with nested data.

I'm wondering if there is a implementation of the "childDocuments" from Solr server.

@floriansemm
Copy link
Owner

The solarium client supports nested documents but is not yet implemented in this bundle

@Mortagus
Copy link
Author

ok thanks for your help :-)

@Mortagus
Copy link
Author

Would it be possible to update the composer.json file ? The solarium library is at the 3.8 version and apparently it's needed to have the nested document feature (if I read correctly the documentation)

@Mortagus Mortagus reopened this Mar 21, 2017
@floriansemm
Copy link
Owner

sure! where is your pull-request? ;)

@Mortagus
Copy link
Author

Can you develop what you mean ?

I've never made any contribution into a github repo before.

How do I do that pull request ?

@Mortagus
Copy link
Author

After some reflexion, I think I know what it is. But I've never done that on github.
Can you give me the procedure, just to be sure I'm not doing something wrong ;-)

@floriansemm
Copy link
Owner

if you want a higher version of the solarium client just run: composer require solarium/solarium:^3.8

@Mortagus
Copy link
Author

This is what I wanted to do, but I discussed this with my coworker, and we decided it was a secondary requirement we didn't want in our composer file. That dependency is linked to your project, so it has to stay there.

It's just about compartmentalizing the dependencies.

@floriansemm
Copy link
Owner

Well, my bundle requires version 3.6 and you need version 3.8, so we speak here about a project-specific dependency.

The next release contains a nested-document feature which requires the version 3.8. If you can wait then you do need to update your project-dependencies.

@Mortagus
Copy link
Author

Hello Florian,

thanks for your answer.
I think you're right. This need is specific to our project so I'm going to update the dependency in our own composer file ;-).

Can I ask your opinion: do you think there will be side effects if we're using the 3.8 version ?

@floriansemm
Copy link
Owner

version 3.8 does not contain critical changes and I have not notice strange behavior with my local setup. So everything should work well.

@Mortagus
Copy link
Author

Hello @floriansemm ,

I'm still on this feature ^^ (a lot of work has been done on other things though).
Now I need to store a list of element as array.
But, like you said in a previous comment: I would need to implement childDocuments.

Can you give me some advice to implement something that would respect good practice ?
Do you think it would be interesting to extend you Field class ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants