Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Launch script does not sanitise .fam category string #3634

Open
csBlueChip opened this issue May 3, 2024 · 0 comments
Open

Minor: Launch script does not sanitise .fam category string #3634

csBlueChip opened this issue May 3, 2024 · 0 comments
Assignees
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related

Comments

@csBlueChip
Copy link

Describe the bug.

If applications_user/fapname/application.fam has a category string which contains a space, the fbt script will break with Error 3

Reproduction

Compiling against FZ 7414e6d4dff582efb6ad716e8268cad03be65c87 :-

cd ~/flipperZero/official/applications_user
mkdir bc_demo
cd bc_demo
git clone https://github.com/csBlueChip/FlipperZero_plugin_howto.git ./
cd ../..
./fbt launch APPSRC=bc_demo

observe the error

2024-05-03 14:35:29,715 [INFO] Launching app: /ext/apps/Cyborg Systems/bc_demo.fap
2024-05-03 14:35:29,726 [ERROR] Unexpected response: Application "/ext/apps/Cyborg" not found
scons: *** [build/f7-firmware-D/site_scons/phony_launch] Error 3

Target

No response

Logs

No response

Anything else?

The obvious workaround is "don't use spaces" ...although the rest of the system is quite happy with them

@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels May 8, 2024
@hedger hedger self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Development

No branches or pull requests

2 participants