Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer ownership of asset and its children to a different account. #983

Merged
merged 4 commits into from Feb 20, 2024
Merged

Transfer ownership of asset and its children to a different account. #983

merged 4 commits into from Feb 20, 2024

Conversation

victorgarcia98
Copy link
Contributor

Description

This PR introduces a new command to transfer the ownership of an asset and its children to a different account.

Look & Feel

flexmeasures edit transfer-ownership --asset 1 --account 2

How to test

Currently, we are not running the CLI test on the GH pipe, please, consider run pytest locally.

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
Transfer ownership of asset and its children to a different account.
37afc75 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Feb 19, 2024
@victorgarcia98
add docs and changelog entries
4b3d8e2 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 marked this pull request as ready for review February 19, 2024 11:35
nhoening
nhoening requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I have just a few improvements.

documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/cli/data_edit.py Outdated Show resolved Hide resolved
flexmeasures/cli/tests/conftest.py Outdated Show resolved Hide resolved
flexmeasures/cli/tests/test_data_edit.py Outdated Show resolved Hide resolved
@victorgarcia98
address change requests
d214d83 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
nhoening
nhoening approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I approve, but I believe I have yet one more valuable tiny improvement to suggest :)

@victorgarcia98
improve conftest
2b94963 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 8b25ae9 into main Feb 20, 2024
9 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/cli/transfer-ownership branch February 20, 2024 11:20
@Flix6x Flix6x added this to the 0.20 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
CLI
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@victorgarcia98 @nhoening @Flix6x