feature(UI): navigate sibling assets/sensors #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
|
Any idea why the Python 3.11 test suite is failing? |
victorgarcia98
approved these changes
Feb 13, 2024
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR let's you navigate sibling assets or sibling sensors in the breadcrumb.
Look & Feel
How to test
Load an asset page or sensor page, preferably one that actually has siblings.
Further Improvements
One idea is to support sibling navigation on any of the ancestors. However, the UX would then need a little rethinking, as the dropdown currently opens on click, and clicking an ancestor already takes you to that ancestor's page. I don't think it's really needed.