Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show child assets in the asset page #967

Merged
merged 5 commits into from Feb 13, 2024

Conversation

victorgarcia98
Copy link
Contributor

Description

This PR introduces a new section to the asset page to list all the child assets of a given asset.

Look & Feel

image


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 marked this pull request as ready for review January 31, 2024 21:24
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you circumvented the internal API as it doesn't support this. I remember you talking about that. Maybe add a comment on the why.
It's a good thing that the internal API gets called before for the parent asset, which will help with auth protection. This does matter.

@Flix6x Flix6x added this to the 0.19.0 milestone Feb 5, 2024
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Copy link
Contributor Author

I see you circumvented the internal API as it doesn't support this. I remember you talking about that. Maybe add a comment on the why. It's a good thing that the internal API gets called before for the parent asset, which will help with auth protection. This does matter.

Finally, I adapted the internal API to return the children (at least, the those of the first level).

Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You found a good solution here (regarding the child asset issue). Great job!

@victorgarcia98 victorgarcia98 merged commit 144ad2a into main Feb 13, 2024
9 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/ui/show-child-assets branch February 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants