New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show child assets in the asset page #967
Conversation
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you circumvented the internal API as it doesn't support this. I remember you talking about that. Maybe add a comment on the why.
It's a good thing that the internal API gets called before for the parent asset, which will help with auth protection. This does matter.
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Finally, I adapted the internal API to return the children (at least, the those of the first level). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You found a good solution here (regarding the child asset issue). Great job!
Description
This PR introduces a new section to the asset page to list all the child assets of a given asset.
Look & Feel