Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Base Image to amd64/ubuntu:22.04 for Compatibility #956

Merged
merged 3 commits into from Jan 29, 2024

Conversation

briskdust
Copy link
Contributor

This Pull Request introduces a change to the base image in our Dockerfile, standardizing it to amd64/ubuntu:22.04. This update is aimed at addressing compatibility issues observed when running our Docker containers on different architectures, particularly on macOS with M1 or M2 chips.

Previously, the Dockerfile used a generic ubuntu image, which led to architecture-related inconsistencies, especially in environments with ARM-based processors like Apple's M2 chips. By explicitly specifying amd64/ubuntu:22.04, we ensure that our Docker environment is consistent across all platforms, leveraging the emulation capabilities for AMD64 architecture on ARM-based systems. This change is crucial for maintaining a uniform development and deployment experience, especially for team members working across different hardware setups.

This update does not affect the functionality of our application but enhances the reliability of our Docker setup in diverse development environments. It's a step towards ensuring that our Docker containers run smoothly, both in development and production settings, regardless of the underlying hardware architecture.

@nhoening nhoening added this to the 0.19.0 milestone Jan 9, 2024
@nhoening
Copy link
Contributor

nhoening commented Jan 9, 2024

Thanks.
I tested make install-for-dev and docker compose build on my Linux system and they still seem to work nicely.
I'll ask two reporters of problems if they can test on their ARM architectures.

@nhoening nhoening merged commit 4304e06 into main Jan 29, 2024
9 checks passed
@nhoening nhoening deleted the fix/update-base-image-for-macos branch January 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants