Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify soc-maxima and soc-minima as a range #899

Merged
merged 21 commits into from Jan 23, 2024

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Nov 11, 2023

Description

Non-breaking API change to support less verbose ways of setting the same constraint for a given time window.

Look & Feel

{
    "flex-model": {
        "soc-maxima": [
            {
                "value": 50,
                "datetime": "2024-02-05T11:00:00+01:00",
            },
            {
                "value": 51,
                "start": "2024-02-05T12:00:00+01:00",
                "end": "2024-02-05T13:30:00+01:00"
            },
            {
                "value": 52,
                "start": "2024-02-05T15:00:00+01:00",
                "duration": "PT1H"
            },
            {
                "value": 53,
                "duration": "PT15M",
                "end": "2024-02-05T18:30:00+01:00"
            }
        ]
    }
}

How to test

  • Still need to check the flexmeasures-client for compatibility.

Further Improvements

  • Update V2G documentation page
  • Update API notation page [not updated, as it points to the V2G documentation page for examples.]
  • Test whether a P1D duration over a DST transition takes into account the sensor's IANA timezone [with 4db562d we now ground the nominal durations to the start or end, and I've added tests for P1M durations. However, I commented out the P1D and P1W test cases, as they require a fundamental fix in isodate.]

Related Items

Closes #898.


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

…time windows

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the API label Nov 11, 2023
@Flix6x Flix6x linked an issue Nov 11, 2023 that may be closed by this pull request
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.19.0 milestone Dec 25, 2023
@Flix6x Flix6x self-assigned this Dec 25, 2023
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…db fixture

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review January 9, 2024 21:50
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…de them upon initialization

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Copy link
Contributor

@victorgarcia98 victorgarcia98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🎆

The only thing is that, perhaps, this should be added to the endpoint docs.

@Flix6x Flix6x merged commit 11b79fc into main Jan 23, 2024
9 checks passed
@Flix6x Flix6x deleted the 898-allow-to-specify-soc-maxima-and-soc-minima-as-a-range branch January 23, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify soc-maxima and soc-minima as a range
2 participants