Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make fallback scheduler redirect optional #891

Merged
merged 4 commits into from Nov 7, 2023
Merged

make fallback scheduler redirect optional #891

merged 4 commits into from Nov 7, 2023

Conversation

victorgarcia98
Copy link
Contributor

Description

FLEXMEASURES_FALLBACK_REDIRECT (default: False) config parameter allows control over the redirect mechanism.

Related Items

#846

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
add fallback scheduler switch mechanism
a1ff141 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Nov 3, 2023
Flix6x
Flix6x requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. But now that we decided to avoid a breaking change altogether, I believe we would no longer require the FLEXMEASURES_FALLBACK_REDIRECT setting. That is, for API v3 it would effectively be hardcoded to False.

flexmeasures/api/v3_0/sensors.py Show resolved Hide resolved
flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved
flexmeasures/api/v3_0/tests/test_sensor_schedules.py Show resolved Hide resolved
flexmeasures/api/v3_0/tests/test_sensor_schedules.py Show resolved Hide resolved
@Flix6x Flix6x added this to the 0.17.0 milestone Nov 7, 2023
@victorgarcia98
remove redundant code
12d3ad8 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 4453ebf into main Nov 7, 2023
9 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/planning/make-fallback-redirect-optional branch November 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
Scheduling Still Needs Changelog Entry
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorgarcia98 @Flix6x