Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose storage and ems power capacities as flex-model fields #850

Merged
merged 18 commits into from Sep 20, 2023
Merged

expose storage and ems power capacities as flex-model fields #850

merged 18 commits into from Sep 20, 2023

Conversation

victorgarcia98
Copy link
Contributor

@victorgarcia98 victorgarcia98 commented Sep 14, 2023 •
edited by Flix6x

Description

This PR exposes the storage and ems power capacities as flex-model fields:

  • name: storage_power_capacity_in_mw, type: Quantity("MW"), required=False
  • name: ems_power_capacity_in_mw, type: Quantity("MW"), required=False

TODO

  • Add changelog entry
  • Confirm name of the new fields

Related Items

Closes #335

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
expose storage and ems power capacities as flex-model fields
eabfeb5 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Sep 14, 2023
@victorgarcia98 victorgarcia98 marked this pull request as ready for review September 14, 2023 12:17
@victorgarcia98
get attribute from generic asset
c583428 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge remote-tracking branch 'origin/feature/planning/expose-ems-and-…
12c1ceb 
…storage-power-capacities-flex-model' into feature/planning/expose-ems-and-storage-power-capacities-flex-model
@victorgarcia98
Merge branch 'main' into feature/planning/expose-ems-and-storage-powe…
451f679 
…r-capacities-flex-model
Flix6x
Flix6x requested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three more todos:

  • a test
  • API documentation in the trigger docstring
  • documentation in the notation.rst flex-model and flex-context sections

flexmeasures/data/schemas/scheduling/storage.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/scheduling/storage.py Outdated Show resolved Hide resolved
flexmeasures/data/models/planning/storage.py Outdated Show resolved Hide resolved
flexmeasures/data/models/planning/storage.py Outdated Show resolved Hide resolved
@victorgarcia98
add test
35925f3 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge remote-tracking branch 'origin/feature/planning/expose-ems-and-…
7590d4c 
…storage-power-capacities-flex-model' into feature/planning/expose-ems-and-storage-power-capacities-flex-model
@victorgarcia98
update description of fleex-model and flex-context
4757452 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
improve validation
72558bb 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add details into trigger_schedule docstring
5dc7855 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add test case and fix docstring
36f0fbc 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
revert tab and remove ç
fa6d005 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x and others added 5 commits September 20, 2023 14:19
@Flix6x
Update sensors.py
72139de 
Revert accidental indentation

Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
@Flix6x
Update sensors.py
ac709d5 
Missing comma

Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
@Flix6x
Update storage.py
5444ef4 
Redacted two more mentions of `storage power capacity`.

Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
@Flix6x
feat(test): check deserialization
271cbdd 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
docs: changelog entries
72d6db9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@victorgarcia98
Merge branch 'main' into feature/planning/expose-ems-and-storage-powe…
16944b9 
…r-capacities-flex-model

Signed-off-by: Victor <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 64beb24 into main Sep 20, 2023
7 of 9 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/planning/expose-ems-and-storage-power-capacities-flex-model branch September 20, 2023 14:08
@Flix6x Flix6x added this to the 0.16.0 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

@nhoening nhoening Awaiting requested review from nhoening

Assignees

@victorgarcia98 victorgarcia98

Labels
Scheduling
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

Add capacity_in_mw to flex model for scheduling
2 participants
@victorgarcia98 @Flix6x