New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spin off fallback scheduler from the storage scheduler #846
Conversation
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly have minor comments, besides the imo unnecessary chaining restriction and possibly a small but consequential bug: I suspect the fallback scheduler is accidentally using the DataSource
of its parent scheduler to save the data (which would undo the primary reason for splitting off the fallback scheduler in the first place). I suggest we explicitly test whether the expected DataSource
is present in the database after the fallback scheduler ran.
Very nice test writing btw!
(I fixed your mypy issue.) |
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…ck' into feature/planning/separate-fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I only have very minor comments left. And if you can add a changelog entry, too, I'd be happy to sign off on this feature.
We can then decide to merge after releasing 0.16, or alternatively we create a release branch for 0.16. The reason why I want to keep this out of 0.16 is because we need to provision clients with the means to adapt to these changes, which you already acknowledge in your main PR description:
- Explain behavior in the docs
- Adapt the FM client
I suggest both of these should be follow-up issues.
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
I've create two follow up issues: |
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor <victor@seita.nl>
Fix my own typo. Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Move changelog entry from 0.16 to 0.17. Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
876ed2c seems not to belong to this PR. |
This reverts commit 876ed2c.
Description
This PR spins the fallback mechanism off the
StorageScheduler
and handles an infeasible schedule by creating a new Job that triggers the fallback scheduler.TODO
trigger_and_get_schedule
should fetch fallback schedule flexmeasures-client#69Related Items