Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add command flexmeasures show chart #833

Merged
merged 13 commits into from Aug 28, 2023
Merged

feature: add command flexmeasures show chart #833

merged 13 commits into from Aug 28, 2023

Conversation

victorgarcia98
Copy link
Contributor

@victorgarcia98 victorgarcia98 commented Aug 24, 2023 •
edited

Description

This PR introduces the command flexmeasures show chart to export sensor and asset charts.

TODO

  • add dependency to app.in
  • update pinned dependency files

Look & Feel

flexmeasures show chart --start 2023-08-15T00:00:00+02:00 --end 2023-08-16T00:00:00+02:00 --asset 1 --sensor 14 --sensor 15 --filename 'chart-$now-$entity_type-$id.png'
  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
add command flexmeasures show chart
85fc4ad 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add test
8636f04 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Aug 24, 2023
@victorgarcia98
add new dependency vl-convert-python
ea74074 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
update app.txt for Python 3.11
5b1efdb 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Add vl-convert-python to Python 3.8 and 3.9 requirements
066da67 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 marked this pull request as ready for review August 25, 2023 08:21
@victorgarcia98
Merge branch 'main' into feature/cli/export-chart
7c177a4 
Signed-off-by: Victor <victor@seita.nl>
Flix6x
Flix6x requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this will be such a time saver!

flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
Flix6x
Flix6x requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment. Also, it looks as if no changes to my previous review have been pushed?

flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
@victorgarcia98
use isoformat and add more variables for the file template
77df312 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
remove assert that doesn't work for multiparagraph docstring
4a20be3 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
move delete_key_recursive to coding_utils.py
b04be0f 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge remote-tracking branch 'origin/feature/cli/export-chart' into f…
e513442 
…eature/cli/export-chart
@victorgarcia98
Copy link
Contributor Author

One more comment. Also, it looks as if no changes to my previous review have been pushed?

You're right, I was trying to fix the test test_cli_help but finally I had to drop one assert as I couldn't get the format of the docstring right.

Flix6x
Flix6x approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text suggestion for the (still missing) main changelog entry:

  • Charts visible in the UI can be exported to PNG or SVG formats in a more automated fashion, using the new CLI command flexmeasures show chart

flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
@victorgarcia98 victorgarcia98 merged commit aa6ae18 into main Aug 28, 2023
3 of 5 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/cli/export-chart branch August 28, 2023 21:26
@Flix6x Flix6x added this to the 0.16.0 milestone Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
CLI Still Needs Changelog Entry
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorgarcia98 @Flix6x