Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated toy-tutorial screenshots #687

Merged
merged 7 commits into from May 24, 2023
Merged

updated toy-tutorial screenshots #687

merged 7 commits into from May 24, 2023

Conversation

Ahmad-Wahid
Copy link
Contributor

Changes Proposed

  • updated asset view, battery discharging schedul,and day-ahead-prices screenshots.
  • added a new asset view after adding data, solar production and updated battery discharging scheduler after considering solar production

closes #631

@Ahmad-Wahid
updated toy-tutorial screenshots
0d321b6 
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
@Ahmad-Wahid Ahmad-Wahid added documentation Improvements or additions to documentation good first issue Good for newcomers UI labels May 18, 2023
@Ahmad-Wahid Ahmad-Wahid linked an issue May 18, 2023 that may be closed by this pull request
Update screenshots in toy tutorial #631
Closed
4 tasks
nhoening
nhoening requested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. It made me think of one way to not just show an empty data plot, but something better.

documentation/tut/toy-example-from-scratch.rst Show resolved Hide resolved
documentation/tut/toy-example-from-scratch.rst Outdated Show resolved Hide resolved
@Ahmad-Wahid
updated screenshots names
f334349 
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Flix6x
Flix6x requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I'd like one more screenshot at the end, and a little spacing after each image (also the final one at the bottom of the page), which can be accomplished by adding this after each image:


|

documentation/tut/toy-example-from-scratch.rst Outdated Show resolved Hide resolved
documentation/tut/toy-example-from-scratch.rst Show resolved Hide resolved
@Flix6x Flix6x mentioned this pull request May 19, 2023
Merged
@Ahmad-Wahid
added new screenshots with some intro
0f7b206 
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Flix6x
Flix6x approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Flix6x Flix6x added this to the 0.14.0 milestone May 22, 2023
@Ahmad-Wahid
reverted the text and update asset view dashboard link
f52a1ca 
Signed-off-by: Ahmad Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
@Ahmad-Wahid Ahmad-Wahid requested a review from nhoening May 23, 2023 07:32
@Ahmad-Wahid
updated text and removed dashboard
133fcc5 
Signed-off-by: Ahmad Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
@Ahmad-Wahid Ahmad-Wahid requested a review from nhoening May 24, 2023 09:48
@nhoening nhoening merged commit fe4c3a9 into main May 24, 2023
7 checks passed
@nhoening nhoening deleted the 631-update-screenshots-in-toy-tutorial branch May 24, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers UI
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

Update screenshots in toy tutorial
3 participants
@Ahmad-Wahid @nhoening @Flix6x