Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tell devs how to get spellright to work in VisualStudio #664

Merged
merged 4 commits into from May 15, 2023
Merged

docs: tell devs how to get spellright to work in VisualStudio #664

merged 4 commits into from May 15, 2023

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented May 4, 2023

No description provided.

@nhoening
docs: tell devs how to get spellright to work in VisualStudio
5ad4c69 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added documentation Improvements or additions to documentation development labels May 4, 2023
@nhoening nhoening requested a review from GustaafL May 4, 2023 14:33
@nhoening
Merge branch 'main' into add-hint-for-devs-using-spellright
a7bf1c6 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
GustaafL
GustaafL requested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@GustaafL GustaafL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is very clear. I added some comments on different phrasing that could be used. The recommendation is a sentence that should be changed. The referencing is up for discussion.

documentation/dev/introduction.rst Outdated Show resolved Hide resolved
documentation/dev/introduction.rst Outdated Show resolved Hide resolved
@nhoening nhoening requested a review from GustaafL May 13, 2023 21:30
GustaafL
GustaafL approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@GustaafL GustaafL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nhoening nhoening merged commit 4b963f5 into main May 15, 2023
6 of 7 checks passed
@nhoening nhoening deleted the add-hint-for-devs-using-spellright branch May 15, 2023 07:09
@Flix6x Flix6x added this to the 0.14.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GustaafL GustaafL GustaafL approved these changes

Assignees
No one assigned
Labels
development documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhoening @GustaafL @Flix6x