Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter not getting picked up in parsed_data after 0.9.5 #603

Open
totycro opened this issue Jan 4, 2024 · 0 comments
Open

Query parameter not getting picked up in parsed_data after 0.9.5 #603

totycro opened this issue Jan 4, 2024 · 0 comments

Comments

@totycro
Copy link

totycro commented Jan 4, 2024

I'm using openapi 3 documentations like this for GET requests with parse=True:

parameters:
- name: feature
  required: false
  in: query
  schema:
    type: string
  explode: true

I've noticed since the upgrade to 0.9.7 that request.parsed_data only contains {'path': {}}, whereas previously it contained also args.

Digging through the code I found that in 0.9.5, parsers were constructed here based on the parameters in the openapi docs:
https://github.com/flasgger/flasgger/blob/0.9.5/flasgger/base.py#L667

In the current version of the code, this has been moved to the method update_schemas_parsers, which is fine, but here it's only executed if the openapi version is 2:

for param in doc.get('parameters', []):

I'm not sure if I'm misunderstanding something here, but shouldn't parsers for parameters be constructed for both openapi version 2 and 3?
If I'm reading the code correctly, then for openapi version 3 only parsers for the body would get constructed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant