Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check usage of context managers #168

Open
heuer opened this issue Apr 7, 2024 · 2 comments
Open

Check usage of context managers #168

heuer opened this issue Apr 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@heuer
Copy link
Contributor

heuer commented Apr 7, 2024

It's a minor issue but several classes provide a context manager where it makes no sense, in my opinion. For example: Where is the use case for a context manager in Output, or CursorManager, or Cursor…?

In my opinion all context managers which have no valid use case should be removed.

@heuer
Copy link
Contributor Author

heuer commented Apr 7, 2024

OutputLayout is another candidate where the value of a context manager is questionable.

@heuer
Copy link
Contributor Author

heuer commented May 7, 2024

@flacjacket, @jwijenbergh, maybe WLR 0.17 offers a chance to clean this up?

However, I don't think this issue is important enough to delay a release of WLR 0.17.

@flacjacket flacjacket added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants