Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Sign In for Client #28

Open
lawrence-vo opened this issue Nov 13, 2022 · 7 comments
Open

SSO Sign In for Client #28

lawrence-vo opened this issue Nov 13, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@lawrence-vo
Copy link

Is there anyway to authenticate via. SSO? I don't mind taking a crack at this, just need to know if it's been implemented or not.

Thanks!

@fixer-m
Copy link
Owner

fixer-m commented Nov 13, 2022

Hi! No, unfortunately this library doesn't support this yet.
You can create dedicated user in SF, allow auth with password for it and use it for this client.

@lawrence-vo
Copy link
Author

@fixer-m would you like me to take a crack at SSO or would you prefer that be implemented at a later time?

@fixer-m
Copy link
Owner

fixer-m commented Nov 19, 2022

@lawrence-vo Sure - you can try to implement it, this would be great actually. I have only demo account in SF, so I guess I can't login via SSO and thus can't properly try and test this auth scheme. I would start with analysing how SSO works in official connector, try to recreate it and simplify it if possible.

@lawrence-vo
Copy link
Author

@fixer-m might take longer as expected since the official client also has issues with SSO.

@fixer-m fixer-m added the enhancement New feature or request label Dec 28, 2022
@tsanton
Copy link

tsanton commented Jan 13, 2023

@lawrence-vo can you link to the issue with the official client?

I just implemented a client credentials flow (OAuth) between DBT and Azure AD for Snowflake.
The project I'm working on requires OAuth-authentication in prod and I'm also utilising this client, therefore I too wouldn't mind taking a stab at as I would love to use this package.

@fixer-m do you have any design ideas for how to implement multiple authentication alternatives?

I'm thinking a IAuthenticator interface... ?

If we can agree on some common patterns then I'd have no problems with creating the AzureOauthAuthenication implementation!

@fixer-m
Copy link
Owner

fixer-m commented Jan 16, 2023

@tsanton Yes, I guess there should be IAuthenticator interface with multiple implementations. I don't know much about OAuth, so right now I can't suggest any design patterns (I would start from researching official connector code).

I have a few requirements though:

  • Try to not break existing public contracts
  • It should be easy to use. Use some common practices and standards
  • It should be easy to add new auth implementations

@lawrence-vo
Copy link
Author

lawrence-vo commented Jan 17, 2023

@tsanton , the issue is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants