Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Middleware behaves differently when switching to late-signing mode #221

Open
TSchmiedlechner opened this issue Nov 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@TSchmiedlechner
Copy link
Member

Describe the bug

When using the late signing mode (via the ftReceiptCaseFlag 0x0000000000010000), the Middleware behaves slightly different in Germany than it does in France or Austria.

  • In Austria and France, the Middleware always returns the ftState 0x...8 when it's operating in late signing mode - no matter if the following receipts have the ftReceiptCaseFlag 0x0000000000010000 (before the zero receipt is sent)
  • In Germany, this ftState is only returned when the mentioned flag is included into the receipts

We should IMO change the German behavior to match the Austrian and French one, because the Middleware in fact obviously stays in late signing mode.

To Reproduce

  1. Send a POS receipt to the Middleware where the ftReceiptCase has the flag 0x0000000000010000
  2. The response will have the expected ftState 0x...8
  3. Send another POS receipt without the flag 0x0000000000010000
    1. In Austria and France, the response will have the ftState 0x...8
    2. In Germany, it will have the state 0x...00

I'm a bit worried though because - depending on the implementation - this could be a breaking change, although IMO that's very unlikely. It may also make sense to fix this with the tagging v2 🤔

@TSchmiedlechner TSchmiedlechner added the bug Something isn't working label Nov 3, 2023
@volllly
Copy link
Contributor

volllly commented Nov 13, 2023

  • Update docs to correctly reflect how the late signing mode works
  • Add to the docs how behaviour in germany currently differs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants