Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies should be sorted as a consistent order is required to #287

Open
github-actions bot opened this issue Dec 25, 2023 · 1 comment
Open
Labels
code:todo A TODO/FIXME comment in code.

Comments

@github-actions
Copy link

compute the same cid. We can't sort Vec<UntypedHandle>, runtime IDs vary each run.


let dependencies = dependencies.iter().cloned().collect::<Vec<_>>();
// TODO: Dependencies should be sorted as a consistent order is required to
// compute the same cid. We can't sort Vec<UntypedHandle>, runtime IDs vary each run.
//
// dependencies.sort();
// For now, gather cids and sort them before update


This issue was generated by todo-issue based on a TODO comment in b5a8f30.
@github-actions github-actions bot added the code:todo A TODO/FIXME comment in code. label Dec 25, 2023
Copy link
Author

Dependencies should be sorted as a consistent order is required to

compute the same cid. We can't sort Vec<UntypedHandle>, runtime IDs vary each run.


// Update Cid with the Cids of it's dependencies
// TODO: Dependencies should be sorted as a consistent order is required to
// compute the same cid. We can't sort Vec<UntypedHandle>, runtime IDs vary each run.
//
// dependencies.sort();
// For now, gather cids and sort them before update


This comment was generated by todo-issue based on a TODO comment in b5a8f30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:todo A TODO/FIXME comment in code.
Projects
None yet
Development

No branches or pull requests

0 participants