Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the possibility of using a OnceMap instead of an AppendOnlyVec for TypeDatas. #260

Open
github-actions bot opened this issue Nov 22, 2023 · 0 comments
Labels
code:todo A TODO/FIXME comment in code.

Comments

@github-actions
Copy link

The only reason we would use a `OnceMap` would be to improve the lookup performance and avoid having to iterate over the entire vec each time we need to find a type data with a particular schema. Since there are not usually a large number of type datas for any single type, this probably isn't a concern, but maybe we should do some benchmarking.


/// This structure doesn't require a mutable reference to insert records
#[derive(Debug)]
// TODO: Evaluate the possibility of using a `OnceMap` instead of an `AppendOnlyVec` for `TypeDatas`.
// The only reason we would use a `OnceMap` would be to improve the lookup performance and avoid
// having to iterate over the entire vec each time we need to find a type data with a particular
// schema. Since there are not usually a large number of type datas for any single type, this
// probably isn't a concern, but maybe we should do some benchmarking.
pub struct TypeDatas(AppendOnlyVec<SchemaBox>);


This issue was generated by todo-issue based on a TODO comment in b865f8f.
@github-actions github-actions bot added the code:todo A TODO/FIXME comment in code. label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:todo A TODO/FIXME comment in code.
Projects
None yet
Development

No branches or pull requests

0 participants