Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group element hash generation restricts range unnecessarily #1121

Open
AaronFeickert opened this issue Jan 7, 2022 · 0 comments
Open

Group element hash generation restricts range unnecessarily #1121

AaronFeickert opened this issue Jan 7, 2022 · 0 comments
Assignees
@levonpetrosyan93

Comments

@AaronFeickert
Copy link
Contributor

The hash-to-group function GroupElement::generate performs a conditional negation that restricts the output range unnecessarily: https://github.com/firoorg/firo/blob/master/src/secp256k1/src/cpp/GroupElement.cpp#L383-L385

This function appears only to be used for generating public parameters, but should be documented as unsafe for future use.
@levonpetrosyan93 levonpetrosyan93 self-assigned this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@levonpetrosyan93 levonpetrosyan93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@levonpetrosyan93 @AaronFeickert