Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [flutter_facebook_auth] Automatically verify email addresses with Facebook sign-in #12769

Closed
lukehutch opened this issue May 11, 2024 · 2 comments
Assignees
Labels
blocked: customer-response Waiting for customer response, e.g. more information was requested. platform: all Issues / PRs which are for all platforms. plugin: auth resolution: invalid This doesn't seem right and might not belong here. type: enhancement New feature or request

Comments

@lukehutch
Copy link

lukehutch commented May 11, 2024

Right now the email address is not trusted in a Facebook sign-in. Refs:

However Flutter Auth has built-in support for email verification. So why not automatically initiate email verification by default for Facebook sign-in, and then mark the email address as trusted once the user has verified they can access that email account?

And actually, rather than throwing the FirebaseAuthException exception with e.code == 'account-exists-with-different-credential' when a user signs in with a trusted email provider and then later signs into Facebook from an account that declares that same email address, why not assume that the email is trusted, as long as the user is signing in from the same device, since the email address was already determined to be verified by the earlier login?

@lukehutch lukehutch added Needs Attention This issue needs maintainer attention. type: enhancement New feature or request labels May 11, 2024
@russellwheatley
Copy link
Member

Hi @lukehutch - FlutterFire will not be deviating from the native Firebase SDKs as we are a thin wrapper around them. As described here, you can use Firebase admin SDK to make it a verified email.

Here is the documentation for handling account existing with different credential.

@russellwheatley russellwheatley added blocked: customer-response Waiting for customer response, e.g. more information was requested. platform: all Issues / PRs which are for all platforms. plugin: auth and removed Needs Attention This issue needs maintainer attention. labels May 13, 2024
@lukehutch
Copy link
Author

OK, I'll close this then. Thanks.

@TarekkMA TarekkMA added the resolution: invalid This doesn't seem right and might not belong here. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: customer-response Waiting for customer response, e.g. more information was requested. platform: all Issues / PRs which are for all platforms. plugin: auth resolution: invalid This doesn't seem right and might not belong here. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants