Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to build matrix, Remove usage of deprecated distutils #2458

Closed
wants to merge 2 commits into from

Conversation

timkpaine
Copy link
Member

This PR prepares perspective for Python 3.12, where distutils has been removed. For our build steps, we now use the vendored distutils inside setuptools, with setuptools pinned to the version currently locked in CI to prevent future breakages. For the one minimal runtime usage, we provide a strtobool function (our usage of this function from distutils was very leftpad-y 馃槃 ).

fixes #2457

@texodus texodus added the internal Internal refactoring and code quality improvement label Dec 2, 2023
@timkpaine
Copy link
Member Author

patched in conda-forge/perspective-feedstock#146, shows as working for python 3.12

@timkpaine timkpaine marked this pull request as draft December 8, 2023 16:18
@timkpaine timkpaine changed the title Remove usage of deprecated distutils Add Python 3.12 to build matrix, Remove usage of deprecated distutils Dec 8, 2023
@timkpaine
Copy link
Member Author

going to close for now, will redo shortly

@timkpaine timkpaine closed this Mar 25, 2024
@timkpaine timkpaine deleted the tkp/distutils branch March 25, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing distutils dependency on python 3.12+
2 participants