Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listFiles must honor globbing better #36

Open
discordier opened this issue Dec 9, 2012 · 3 comments
Open

listFiles must honor globbing better #36

discordier opened this issue Dec 9, 2012 · 3 comments

Comments

@discordier
Copy link
Member

listFiles() should not fetch all files and filter them after then.

For slow FS this is plain evil.

i.e.: glob = lib/*

FTP fetches all dirs in root but could rule all except fot /lib out forehand.

@tristanlins
Copy link
Member

According to our call you wan't recursive glob patterns like lib/**, not recursive listing with globing.

@ghost ghost assigned tristanlins Dec 10, 2012
@leofeyer
Copy link

When you are working on this, you might want to look into the Symfony Finder improvements.

http://symfony.com/blog/new-in-symfony-2-2-finder-improvements
https://gist.github.com/jfsimon/3230139
symfony/symfony#4061

They are using native commands where available instead of the PHP functions.

@tristanlins
Copy link
Member

We need to check the performance and implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants