Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform-ui - crop options missing #547

Open
guillermo-vazquez opened this issue Jan 26, 2024 · 3 comments
Open

transform-ui - crop options missing #547

guillermo-vazquez opened this issue Jan 26, 2024 · 3 comments

Comments

@guillermo-vazquez
Copy link

guillermo-vazquez commented Jan 26, 2024

Related to the transform-ui crop functionality, Only '16/9' option is visible.
Free, circle and square options are missing, for both default and explicit config (radios property).


Screenshot 2024-01-26 at 1 01 42 PM

We were using the below CDN, then we noticed the problem.
https://static.filestackapi.com/transforms-ui/2.x.x/transforms.umd.min.js

Downgrading to below, solved our problem.
https://static.filestackapi.com/transforms-ui/2.0.2/transforms.umd.min.js

The problem seems to be introduced on below.
https://static.filestackapi.com/transforms-ui/2.0.3/transforms.umd.min.js

The problem is visible and reproducible on your own demo page.
https://www.filestack.com/docs/transformations/ui/web/

Expected Behavior

Chop options free, circle, square and '16/9', expected on default or explicit config.

Current Behavior

Chop options free, circle and square are missing.

Possible Solution

Steps to Reproduce (for bugs)

The error is visible and reproducible on your own demo page.
https://www.filestack.com/docs/transformations/ui/web/

Additional Screenshots

transforms-ui/2.0.3

Screenshot 2024-01-26 at 2 14 15 PM

transforms-ui/2.0.2

Screenshot 2024-01-26 at 2 16 27 PM

Context

We got our work around, but anyone using the transform-ui 2.x.x is impacted by this defect.

Your Environment

We were using the below CDN, then we notice that the problem.
https://static.filestackapi.com/transforms-ui/2.x.x/transforms.umd.min.js

Downgrading to below, solved our problem.
https://static.filestackapi.com/transforms-ui/2.0.2/transforms.umd.min.js

The problem seems to be introduced on below.
https://static.filestackapi.com/transforms-ui/2.0.3/transforms.umd.min.js

@jartaud
Copy link

jartaud commented Feb 2, 2024

Downgrade to 2.0.2 is not working for me. The following works:

const tr = new FilestackTransform('API_KEY');

tr.setConfig({
    editor: {
        transforms: {
            ratios: [
                {
                    icon:      'crop_free',
                    // default:   true,
                    // name:      'Custom',
                    // shape:     'rect',
                    // lockRatio: false,
                    isShow:    true,
                },
                {
                    icon:      'panorama_fish_eye',
                    // name:      'Circle',
                    // shape:     'circle',
                    // lockRatio: true,
                    isShow:    true,
                },
                {
                    icon:      'crop_square',
                    // name:      'Square',
                    // shape:     'rect',
                    // ratio:     1,
                    // lockRatio: true,
                    isShow:    true,
                },
                {
                    icon:      'crop_16_9',
                    // name:      '16/9',
                    // shape:     'rect',
                    // ratio:     16/9,
                    // lockRatio: true,
                    isShow:    true,
                },
            ],
        },
    },
});

https://github.com/filestack/filestack-js/assets/266818/dbd69df7-e367-4d9b-892a-595370e9c75e

Showcase

@subasically
Copy link

A downgrade to 2.0.2 worked for me.

1 similar comment
@webdevsps
Copy link

A downgrade to 2.0.2 worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants