Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for theme packs #15297

Open
hishitetsu opened this issue May 3, 2024 · 7 comments
Open

Feature: Support for theme packs #15297

hishitetsu opened this issue May 3, 2024 · 7 comments

Comments

@hishitetsu
Copy link
Member

What feature or improvement do you think would benefit Files?

We are going to support for displaying a background image. It would make the distribution of themes for Files easier if the theme could be changed by double-clicking on a theme pack file, which contains a background image and other theme settings.

Requirements

  • Theme pack files have .filestheme extension.
  • A theme pack file is actually a zip archive, which contains an image file for the background and a json file which stores theme settings.
  • If the user opens a theme pack file, Files applies the background image and other theme settings contained within it.

Files Version

3.3.6.0

Windows Version

10.0.22631.3447

Comments

No response

@yaira2
Copy link
Member

yaira2 commented May 5, 2024

Thank you for your feedback

@TimoNotThy
Copy link

Wouldn't it make more sense to use CSS? How are the build-in "themes" currently implemented?

@Josh65-2201
Copy link
Member

CSS is for web browsers and Files isn't a web site or based on one. Currently there values in settings that get applied across Files code base in XAML

@0x5bfa
Copy link
Member

0x5bfa commented May 30, 2024

We have zip extractor inside of the codebase so making .filestheme as zip is a good idea.
We should register in our new database and show them like Windows Settings app does.

@TimoNotThy
Copy link

For ease of use I would not put it in any type of archive, this way it's easy to edit without having to unzip and zip constantly. Another solution would be to have it work like how Minecraft does texturepacks, having both folders and zip files work.

@Josh65-2201
Copy link
Member

Josh65-2201 commented May 30, 2024

You wouldn't have to un-zip and re-zip to edit and test, at most it will be import > edit what you want > export. That's really as small as it can go. It stored as a zip when finalized so that all the files are available and easy to move around. Windows themes work the same just under a different extension.

@0x5bfa
Copy link
Member

0x5bfa commented May 30, 2024

No reason to edit by your own it probably makes worsen because once it break you have to creat new one with correct names and configurations. So as @Josh65-2201 said, being archive is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Planning stage
Development

No branches or pull requests

5 participants