Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fallback to default config #11917

Open
3 of 9 tasks
ZenGround0 opened this issue Apr 22, 2024 · 1 comment
Open
3 of 9 tasks

Allow fallback to default config #11917

ZenGround0 opened this issue Apr 22, 2024 · 1 comment
Labels
kind/feature Kind: Feature

Comments

@ZenGround0
Copy link
Contributor

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Last year we set up lotus to never fallback to the default config. The reasoning was that the default config enabled splitstore discard and so default configs are dangerous for users to rely on as they were not yet used to a world with chain store discarding as the default.

It has been a year so I think everyone is pretty well warned. If not we need to find out how to properly warn them now.

Describe the solution you'd like

Remove the default config disallowing option.

Describe alternatives you've considered

We could just keep this forever but it is needlessly inconvenient.

Additional context

This came up because of a bug in a rare code / state path in lotus daemon hit by Zondax that hit this error without benefit.

@ZenGround0 ZenGround0 added the kind/feature Kind: Feature label Apr 22, 2024
@rjan90
Copy link
Contributor

rjan90 commented Apr 24, 2024

Agree on reverting back to the default config now, and setting SpliStore enable as default now that it has been in trasition for over a year.

The disallowing option also seem to cause a issue for Lite-nodes, which needs to explicitly set it as well: filecoin-project/lotus-docs#647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Kind: Feature
Projects
None yet
Development

No branches or pull requests

2 participants