Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA #12662

Open
danharrin opened this issue May 7, 2024 · 1 comment
Open

2FA #12662

danharrin opened this issue May 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@danharrin
Copy link
Member

No description provided.

@danharrin danharrin added the enhancement New feature or request label May 7, 2024
@danharrin danharrin added this to the v4 milestone May 7, 2024
@danharrin danharrin self-assigned this May 7, 2024
@binaryfire
Copy link
Contributor

binaryfire commented May 8, 2024

I recently implemented 2FA and had to make it pretty flexible, so figured I'd share some feedback:

  • I needed it to be configurable per guard because I've got both Admin and Member models, and each has different security requirements
  • The option to enforce it for all users was also configurable per guard
  • All the options (enable/disable/enforce) were implemented as settings in a landlord panel, so it'd be great to make everything dynamically configurable rather than hardcoded in the config file
  • I used the session to store the 2FA auth status so I could programmatically mark it as completed when using my custom SSO (SSO logins normally skip 2FA since the SSO provider handles it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants