Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support for the server #67

Open
AleksanderMako opened this issue Jun 30, 2021 · 3 comments
Open

Add Docker support for the server #67

AleksanderMako opened this issue Jun 30, 2021 · 3 comments
Assignees

Comments

@AleksanderMako
Copy link

run the NLP server inside a docker container to make running the server practical

@fhamborg fhamborg self-assigned this Jul 1, 2021
@fhamborg
Copy link
Owner

fhamborg commented Jul 1, 2021

thanks for your mail and the issue report - i just read this issue after getting your mail. could you let me know, what issues were you facing that made starting and running the corenlp server "impractical"? we do provide a simple command (see readme.md) to startup the server so im unsure how this is not practical. or did you face an issue when starting up the server?

@AleksanderMako
Copy link
Author

I had a few issues:

  1. I did not want to install jdk in my computer to run the server.
  2. The server has some dependency to wget and I did not want to install that either.
  3. There was a dependency on some unziping tool as well which I did not have and also did not want to install.
  4. I saw that you can change the port that the Giveme5W1H library tries to dial but I did not see how I could change it if I needed to. Maybe I did not look hard enough though for this particular case.
  5. This is more of a comment but ever since I managed to run the command you provide inside a container I have been able to reproduce the desired behaviour every time and I think in general Docker would provide some stability in running the server reliably.
  6. Lastly I am not saying I my way is the best way or that my Docker support is actually the best it could I put it together from wherever I could but just wanted to share an idea that might make the project better and easier to use :)

@fhamborg
Copy link
Owner

fhamborg commented Jul 2, 2021

I understand your comments. In general, I want to keep our repos as lean as possible, i.e., so that they focus on only the core functionality (which here is the 5W1H extraction). Only for convenience, we added this "download and run" command for the server. Having two ways of doing this function also means having two things to support and generally I try to avoid redundancy. However, in case the docker version is more convenient, I might add it and perhaps remove the current way Feel free to open a PR for me and my colleagues to have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants