Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for role=figure instead of role=group for figures #392

Open
ffoodd opened this issue Aug 18, 2020 · 0 comments
Open

Check for role=figure instead of role=group for figures #392

ffoodd opened this issue Aug 18, 2020 · 0 comments

Comments

@ffoodd
Copy link
Owner

ffoodd commented Aug 18, 2020

Hi. I greatly value a11y.css as a tool for quick assessment, but this warning about role="group" throws me off every time...

There is an open ticket on the referenced WAI Tutorial repo indicating that, as of 2017, ARIA 1.1 provides role="figure". Since this is the implicit ARIA role of the <figure> tag, shouldn't this be the correct role to assign, rather than overriding it with group? An investigation by Scott O'Hara and his markup recommendation seem to support that as well: https://www.scottohara.me/blog/2019/01/21/how-do-you-figure.html

PS: I summarized my "research" on the issue on my blog.

Originally posted by @sebastiangreger in #121 (comment)

@ffoodd ffoodd self-assigned this Aug 18, 2020
@ffoodd ffoodd changed the title Check for role=figure instead of role=group for fgirues Check for role=figure instead of role=group for figures Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant