Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why using Ids? #69

Open
LudovicDubois opened this issue May 18, 2021 · 0 comments
Open

Why using Ids? #69

LudovicDubois opened this issue May 18, 2021 · 0 comments

Comments

@LudovicDubois
Copy link

Why do you use an id to create the api.player?
We can provide a selector or an element.
Then you search for the corresponding element to find its id to pass to api.player constructor.
If we provide an element, you are searching for it's ID to provide to api.player so that it can search for the element!

Problem is, in a Virtual DOM, the api.player cannot access the inner element of a virtual DOM. Passing the element itself solves the problem.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant