Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks #77

Open
10 of 14 tasks
g-bauer opened this issue Nov 15, 2022 · 2 comments
Open
10 of 14 tasks

Add benchmarks #77

g-bauer opened this issue Nov 15, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@g-bauer
Copy link
Contributor

g-bauer commented Nov 15, 2022

Following #65, we should add benchmarks for possible future performance investigations.
Feel free to add to the list of functions to benchmark.

Notes

  • Compare impact of compiler options
    • lto = "thin" versus lto = true
    • target-cpu=native
    • and more?
@g-bauer g-bauer added enhancement New feature or request help wanted Extra attention is needed labels Nov 15, 2022
@prehner
Copy link
Contributor

prehner commented Dec 29, 2022

I added DFT benchmarks in #103. Comparing different solvers in a benchmark is not useful imo, because it gives a very limited insight into the capabilities of the solver.

Do you have a specific thought on how to identify Python overhead? For DFT it appears to be of the order of 2-3 ms, but very difficult to assess property.

@g-bauer
Copy link
Contributor Author

g-bauer commented Jan 2, 2023

Do you have a specific thought on how to identify Python overhead? For DFT it appears to be of the order of 2-3 ms

I am note sure. There are options to run Python code using pyo3 (run, eval, from_code, etc.) but I am not sure if we can use these to make proper comparisons or get an idea of the overhead of a function/method. 2-3 ms seems to be a lot, though. Does that include calling a property that returns a numpy array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants