Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make critical point calculation more robust #236

Open
g-bauer opened this issue Apr 11, 2024 · 0 comments
Open

Make critical point calculation more robust #236

g-bauer opened this issue Apr 11, 2024 · 0 comments
Labels
core related to features in feos-core enhancement New feature or request

Comments

@g-bauer
Copy link
Contributor

g-bauer commented Apr 11, 2024

Depending on initial values, the critical point routine may return the wrong state. We currently only check if the result for a temperature is OK (and then we don't check additional temperatures) but a more rigorous check is needed.

@g-bauer g-bauer added enhancement New feature or request core related to features in feos-core labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core related to features in feos-core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant