Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutoff_radius limit not necessary in structured (periodic) porous media? #202

Open
RolfStierle opened this issue Nov 24, 2023 · 1 comment
Labels
DFT DFT related feature or issue help wanted Extra attention is needed

Comments

@RolfStierle
Copy link
Contributor

if system_size.iter().any(|&s| s < 2.0 * cutoff_radius) {

For periodic porous media, wouldn't we want to include the molecular interactions of the periodic images, since the porous media is also periodic? This would make this check obsolete.

@prehner
Copy link
Contributor

prehner commented Nov 24, 2023

Yes, but currently FeOs only determines the closest periodic image for every solid atom rather than every periodic image within the cutoff. When this is fixed, the check becomes obsolete.

@g-bauer g-bauer added good first issue Good for newcomers DFT DFT related feature or issue help wanted Extra attention is needed and removed good first issue Good for newcomers labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DFT DFT related feature or issue help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants