Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README should state that PHP 7.1 is the minimum version required #452

Open
rkaiser0324 opened this issue Oct 4, 2019 · 0 comments · May be fixed by #459
Open

README should state that PHP 7.1 is the minimum version required #452

rkaiser0324 opened this issue Oct 4, 2019 · 0 comments · May be fixed by #459

Comments

@rkaiser0324
Copy link

I think this is the right place as it is a doc issue with the extension. In the README, which presumably drives the extension documentation in VS.Code, it says

You need at least PHP 7 installed for the extension to work.

However, the language server requires 7.1 at a minimum, and VS.Code will bark at you if you try 7.0 as I did. So the README here should be changed to reflect that.
rkaiser0324 added a commit to rkaiser0324/vscode-php-intellisense that referenced this issue Dec 7, 2019
@rkaiser0324
doc: update required PHP version number to 7.1
c3481b9 
Fixes felixfbecker#452
@rkaiser0324 rkaiser0324 linked a pull request Dec 7, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update required PHP version number to 7.1 rkaiser0324/vscode-php-intellisense
1 participant
@rkaiser0324