Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: value is undefined at content.ts:28:8 #79

Open
meithecatte opened this issue May 22, 2021 · 5 comments
Open

TypeError: value is undefined at content.ts:28:8 #79

meithecatte opened this issue May 22, 2021 · 5 comments
Labels
bug Something isn't working needs-more-info

Comments

@meithecatte
Copy link

Steps to reproduce:

  1. Visit https://cloud.binary.ninja
  2. Click "Capture viewport" in the extension's menu.
  3. Observe error:
    svg-error
@felixfbecker
Copy link
Owner

I can't reproduce this error. Could you tell me which version, browser and settings you're using?

@meithecatte
Copy link
Author

I am using Firefox 88.0.1 and SVG Screenshot 0.11.0. I can see that addons.mozilla.org has 0.11.1 and GitHub has 0.11.2, so this might be due to my using an outdated version. I don't see how to update it, though. I seem to have automatic updates enabled, and even a manual "check for updates" doesn't notice the new version...
updates

@meithecatte
Copy link
Author

These are the settings I'm using, FWIW.
settings

@felixfbecker felixfbecker added needs-more-info bug Something isn't working labels May 24, 2021
@felixfbecker
Copy link
Owner

felixfbecker commented May 24, 2021

The release pipeline was broken on Firefox because it now requires 2FA, thanks for letting me know!

The Firefox extension should be up to date now. Could you update to 0.11.6 and let me know if you still have this issue?

FWIW I tried it with the previous version and didn't have the error. Maybe we're not seeing the same content on the page, are you signed in? I'm seeing this:

image

Which is producing this SVG for me:

Binary Ninja Cloud Screenshot.svg.zip

Firefox 88.0.1, macOS.

@felixfbecker
Copy link
Owner

If it's not updating, try uninstalling and reinstalling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-more-info
Projects
None yet
Development

No branches or pull requests

2 participants