Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Git setup automation doesn't quite work for GitLab #3731

Open
onierstrasz opened this issue Apr 25, 2024 · 13 comments
Open

The Git setup automation doesn't quite work for GitLab #3731

onierstrasz opened this issue Apr 25, 2024 · 13 comments
Assignees
Labels
Projects

Comments

@onierstrasz
Copy link
Contributor

The Git setup dialog works fine for GitHub projects but not quite for GitLab.
(1) When creating the baseline, the initialization breaks at some point with a PP2Failure. The consequence appears to be just that the README is not correctly initialized with the Metacello load script.
Screenshot 2024-04-25 at 14 57 10
(2) The load script needs to be adapted to use the master branch rather than the main branch. It seems the latter is standard for GitHub, but not for GitLab.

@onierstrasz onierstrasz added this to To do in GT via automation Apr 25, 2024
@StephanEggermont
Copy link
Contributor

Default branch for gitlab is main too according to the documentation

@onierstrasz
Copy link
Contributor Author

🤷‍♂️When I created a blank project and loaded it into GT I got a master branch.

@hellerve
Copy link
Member

Is this gitlab.com or a self-hosted GitLab instance? If it’s self-hosted, which version is it? On gitlab.com, the default branch is indeed main; I just created one myself.

@onierstrasz
Copy link
Contributor Author

Good question. I thought it was gitlab.com, but maybe it is a unibe hosted instance. I'll have to check!

@hellerve
Copy link
Member

Thank you! In the meantime, I’ve fixed the other issue. The parser should now also handle gitlab.com (but not self-hosted instances!). It will also throw a hopefully more instructive error when trying to add the Baseline information to the README otherwise.

syrel pushed a commit that referenced this issue Apr 26, 2024
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.707/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/pharo-futures@37aa3b by Andrei Chi�
Prevent pool workers from being interrupted [#3732]

feenkcom/Bloc@a56967 by akevalion
[#3729] update width to half

feenkcom/Bloc@9cd335 by akevalion
Merge 717a84a6fcc9d1da0a65d9b7a8b0cf818276adc2

feenkcom/Bloc@98a1e9 by akevalion
[#3729] horizontal and vertical lines now react to mouse events

feenkcom/bloc-pac@8eb391 by akevalion
[#3729] update examples to include the new computation

feenkcom/gtoolkit-coder@cd97eb by Veit Heller
Merge 5c633be17a744b1d96198640a317640c3b929597

feenkcom/gtoolkit-coder@2152c4 by Veit Heller
Add disjunction for searches

feenkcom/gtoolkit-debugger@3c09f1 by Andrei Chi�
Use #debuggerCompleteToSender to get better filtering

feenkcom/gtoolkit-debugger@b65c3d by Andrei Chi�
Update example strings in GtExampleComparisonExceptionWithDebuggingViews

feenkcom/gtoolkit-debugger@014640 by Andrei Chi�
Add a view for debugger specifications

feenkcom/zinc@24439f by svenvc
Merge 1a89da3f89fa6d5ccc76f30d05b548c3ce96b93e

feenkcom/zinc@7cdfd4 by svenvc
make ZnTooManyRedirects more intelligent (add a trail of followed URLs and two resume behaviors)

feenkcom/gtoolkit-releaser@50ba70 by Tudor Girba
add utility for querying GT specific classes and traits

feenkcom/lepiter@7ba5a7 by svenvc
AutomaticCounter comment update

feenkcom/lepiter@c01a1e by svenvc
temporary adding AutomaticCounter[Element] to Lepiter-Snippet-Shell

feenkcom/gt4git@f8c982 by Veit Heller
Allow for Gitlab URLs in adding Baselines to README [#3731]

feenkcom/gtoolkit-world@b67e74 by Andrei Chi�
Extract the creation of the aptitude for the space tab in a dedicated method

feenkcom/gtoolkit-world@401650 by Andrei Chi�
Rename again #gtComparableTypesDiffFor:

feenkcom/gt4gemstone@9d2788 by Andrei Chi�
Register only the expandable gemstone debugger

124067 by Tudor Girba
add page about prices design #3734

4484b8 by Andrei Chi�
Merge 4d56a0f

2f1ee4 by Andrei Chi�
Add a diff example for more complex strings

4d56a0 by Oscar Nierstrasz
Added a page about using GitLab
@onierstrasz
Copy link
Contributor Author

Nice! Though there seems to be an unnecessary st now in the installation script. Can you please check, @hellerve ?

Screenshot 2024-04-28 at 14 19 05

@hellerve
Copy link
Member

I didn’t change it, but that is a Smalltalk syntax cue (https://www.markdownguide.org/extended-syntax/#syntax-highlighting). It should be supported by GitHub, GitLab, and GT.

@onierstrasz
Copy link
Contributor Author

That's odd. Until I deleted it, it messed up the display of the README on my test repo on GitLab.
Can't we get rid of it?

@onierstrasz
Copy link
Contributor Author

Well, now I can't reproduce the problem. I will have to create a new repo and see if I can recreate the issue ...

@onierstrasz
Copy link
Contributor Author

OK, I verified that it does not work in GitLab.
Is it possible to remove the st syntax cue for GitLab?

Screenshot 2024-04-29 at 07 54 26

@girba
Copy link
Member

girba commented Apr 29, 2024

Can you try adding an empty line after Installation?

Also, if that does not help, what happens if you use smalltalk instead of st?

@onierstrasz
Copy link
Contributor Author

Oh, with Andreas we discovered that the problem is that the newlines are wrong, not the st!
Just editing the README on the GitLab web page and saving it fixes the issues.

@hellerve
Copy link
Member

Hm, it looks like GitLab expects specific newlines where GitHub is happy with any. We are not doing anything specific to the newlines in the file, so this is the default behaviour with regards to newlines.

I’ll leave the st as is for now, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
GT
  
To do
Development

No branches or pull requests

4 participants