Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for camera permission before launching gallery #944

Open
pratistha-05 opened this issue Nov 16, 2023 · 2 comments
Open

Ask for camera permission before launching gallery #944

pratistha-05 opened this issue Nov 16, 2023 · 2 comments
Assignees
@pratistha-05
Labels
Development Help appreciated Improvements

Comments

@pratistha-05
Copy link

pratistha-05 commented Nov 16, 2023 •
edited

Current Behaviour: while adding photos, OmniNotes opens up gallery without prompting user to give permission
Expected Behaviour: while adding photos, the app should pop up a dialog box that asks user for permission for camera access
image
@federicoiosue can you please assign this issue to me , so that I can get started.
@federicoiosue
Copy link
Owner

Hi Pratistha, if you mean to move the camera permission to runtime management feel free to start working on this.
Please follow the contributing guidelines.

akashs056 added a commit to akashs056/Omni-Notes that referenced this issue Dec 24, 2023
@akashs056
fixed federicoiosue#944 : Ask for camera permission before launching …
14c3871 
…gallery

Added Methods like
- checkCameraPermission
- requestCameraPermission

And requested permision from the user to take photos or record vedios
pratistha-05 pushed a commit to pratistha-05/Omni-Notes that referenced this issue Dec 26, 2023
fix for federicoiosue#944 : Ask for camera permission before launchin…
da4bd03 
…g gallery
@pratistha-05
Copy link
Author

We can also add runtime permission for accessing files. Can I improvise this in same PR @federicoiosue ?

federicoiosue added a commit that referenced this issue Mar 10, 2024
@federicoiosue
Merge pull request #955 from pratistha-05/improvement/camera_permission
dbfc00d 
improvement: adding runtime permission issue: #944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratistha-05 pratistha-05

Labels
Development Help appreciated Improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@federicoiosue @pratistha-05