Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment _create_object should not be in experiment class #1072

Open
srcansiz opened this issue Mar 28, 2024 · 1 comment
Open

Experiment _create_object should not be in experiment class #1072

srcansiz opened this issue Mar 28, 2024 · 1 comment
Labels
candidate an individual developer submits a work request to the team (extension proposal, bug, other request)

Comments

@srcansiz
Copy link
Member

The method _create_object in experiment is very complex and it is only used for aggregator and node selection strategy. I propose to remove this method and implement loading objects using class methods of the base classes Aggregator.load and Stragety.load. This will reduced the complexity. The implementation can be similar to Optimizer classes

@srcansiz srcansiz added the candidate an individual developer submits a work request to the team (extension proposal, bug, other request) label Mar 28, 2024
@ybouilla
Copy link
Contributor

ybouilla commented Apr 2, 2024

I think the implementation of _create_object can be less complex if we delegate the part of passing training_plan as parameter to methods such as Aggregator.load or Strategy_load.

I don't know if we can do better, because the original attempt was to make possible to load Strategy and Aggregator with custom modules, that could be located outside aggregator or strategies folders. But we may want to remove this feature if we consider it not too relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate an individual developer submits a work request to the team (extension proposal, bug, other request)
Projects
None yet
Development

No branches or pull requests

2 participants