Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feathers-sequelize remove method rewrite breaking change when deleting multiple items without id in table #409

Open
chrisbag opened this issue Jan 4, 2023 · 0 comments

Comments

@chrisbag
Copy link

chrisbag commented Jan 4, 2023

Hey,
Just experienced a breaking change when updating to latest feathers-sequelize so thought it might be helpful if ever other people encounter this bug :)

Steps to reproduce

remove service method when removing multiple entires (null parameter) fails when table has no ID following recent method rewrite
Some tables such has join tables don't necessarily need an ID
in the new remove method, items are fetched and then removed by ID causing the request to fail if no ids exist
this is the SQL raw query : DELETE FROM "join_table" WHERE "id" IN (NULL)
#403

Expected behavior

Should be able to delete multiple items in a table without ids or at least get an error message

Actual behavior

Code runs without error message and without deleting the entries

System configuration

feathers-sequelize 6.4.0

@chrisbag chrisbag changed the title feathers-sequelize remove method rewrite breaking change feathers-sequelize remove method rewrite breaking change when deleting multiple items without id in table Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant